[PATCH] D142307: [clang-tidy][NFC] Use C++17 nested namespaces in clang-tidy headers

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 22 09:34:20 PST 2023


Eugene.Zelenko accepted this revision.
Eugene.Zelenko added a comment.
This revision is now accepted and ready to land.

Looks OK for me, but please fix small formatting issues. Will be good idea to await for other eyes.



================
Comment at: clang-tools-extra/clang-tidy/utils/FixItHintUtils.h:47
                       QualifierPolicy CP = QualifierPolicy::Left);
-} // namespace fixit
-} // namespace utils
-} // namespace tidy
-} // namespace clang
+} // namespace clang::tidy::utils::fixit
 
----------------
Please separate with newline.


================
Comment at: clang-tools-extra/clang-tidy/utils/IncludeInserter.h:19
 namespace clang {
 class Preprocessor;
+namespace tidy::utils {
----------------
Ditto.


================
Comment at: clang-tools-extra/clang-tidy/utils/IncludeSorter.h:75
 };
-} // namespace tidy
-} // namespace clang
+} // namespace clang::tidy
 #endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_INCLUDESORTER_H
----------------
Ditto,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142307/new/

https://reviews.llvm.org/D142307



More information about the cfe-commits mailing list