[PATCH] D142167: [clang][modules] Disallow importing private framework in the implementation

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 17:04:21 PST 2023


jansvoboda11 added inline comments.


================
Comment at: clang/lib/Sema/SemaModule.cpp:544
   // FIXME: Should we warn on a redundant import of the current module?
-  if (Mod->getTopLevelModuleName() == getLangOpts().CurrentModule &&
+  if (Mod->isForBuilding(getLangOpts()) &&
       (getLangOpts().isCompilingModule() || !getLangOpts().ModulesTS)) {
----------------
This is the functional change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142167/new/

https://reviews.llvm.org/D142167



More information about the cfe-commits mailing list