[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

Yueh-Ting (eop) Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 7 07:38:45 PST 2023


eopXD added a comment.

The testing time difference is shown below. I personally think 3 more minutes in testing is tolerable when considering `check-all`. The testing time increase comes from full test coverage to the intrinsics. Before this patch, some test cases only includes parts of the {SEW, LMUL} combination of an intrinsic to reduce avoid long compile time. We no longer suffer from long compile time as the intrinsics are now lazily added.

Before

  $ bin/llvm-lit ../clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded ../clang/test/CodeGen/RISCV/rvv-intrinsics ../clang/test/CodeGen/RISCV/rvv-intrinsics-handcrafted
  llvm-lit: /scratch/eopc/upstream-llvm-project/llvm/utils/lit/lit/llvm/config.py:459: note: using clang: /scratch/eopc/upstream-llvm-project/build/bin/clang
  -- Testing: 326 tests, 48 workers --
  Testing Time: 25.83s
    Passed: 326

After

  $ bin/llvm-lit ../clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated
  llvm-lit: /scratch/eopc/upstream-llvm-project/llvm/utils/lit/lit/llvm/config.py:459: note: using clang: /scratch/eopc/upstream-llvm-project/build/bin/clang
  -- Testing: 566 tests, 48 workers --
  Testing Time: 225.61s
    Passed: 566


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141198/new/

https://reviews.llvm.org/D141198



More information about the cfe-commits mailing list