[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 17 07:32:27 PST 2022


steakhal added a comment.

In D138037#4003121 <https://reviews.llvm.org/D138037#4003121>, @vabridgers wrote:

> Hi @steakhal, thanks for the suggested change.
> How we can help move this forward? From what I'm comprehending from the notes, perhaps we could try running this change through our internal systems level test and fuzzer. Unfortunately, I'd not be able to say more than "trust me, we saw no problems" if we see no problems. But if I do find additional cases I can make simplified reproducers and we can work on addressing those.
> Best!

Well, I totally forgot about this change. I think we could evaluate if keeping alive the representatives would help or not.
However, I cannot push this. I dont have the bandwidth.

I'd be interrested to see other crashing cases you mentioned.
Keep me informed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138037/new/

https://reviews.llvm.org/D138037



More information about the cfe-commits mailing list