[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

Fri Dec 16 10:31:11 PST 2022

manojgupta added a comment.

Here are a few instances of Xcompiler usage for a non-exhaustive search (I can't look inside package tarballs if they are using it ):

https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/main/net-vpn/openvpn/openvpn-2.4.4.ebuild#74
https://chromium.googlesource.com/external/googleappengine/python/+/bedccc3dd4178880371cdf44064b222d82a5f30d/lib/distutils/distutils/extension.py#219

We already ignore Xcompiler for GCC in our compiler wrapper (https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/main/compiler_wrapper/gcc_flags.go), and we can do the same for clang as well.
So in theory, we'll be ok with the removal but it is annoying for sure to deal with.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140224/new/

https://reviews.llvm.org/D140224