[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h
Saleem Abdulrasool via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 15 13:51:26 PST 2022
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe0c3142af075: Headers: tweak inclusion condition for stdatomic.h (authored by compnerd).
Changed prior to commit:
https://reviews.llvm.org/D139266?vs=480531&id=483327#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139266/new/
https://reviews.llvm.org/D139266
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Headers/stdatomic.h
Index: clang/lib/Headers/stdatomic.h
===================================================================
--- clang/lib/Headers/stdatomic.h
+++ clang/lib/Headers/stdatomic.h
@@ -15,10 +15,12 @@
*
* Exclude the MSVC path as well as the MSVC header as of the 14.31.30818
* explicitly disallows `stdatomic.h` in the C mode via an `#error`. Fallback
- * to the clang resource header until that is fully supported.
+ * to the clang resource header until that is fully supported. The
+ * `stdatomic.h` header requires C++ 23 or newer.
*/
#if __STDC_HOSTED__ && \
- __has_include_next(<stdatomic.h>) && !(defined(_MSC_VER) && !defined(__cplusplus))
+ __has_include_next(<stdatomic.h>) && \
+ !(defined(_MSC_VER) && defined(__cplusplus) && __cplusplus < 202002L)
# include_next <stdatomic.h>
#else
Index: clang/docs/ReleaseNotes.rst
===================================================================
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -199,6 +199,8 @@
Bug Fixes
---------
+- ``stdatomic.h`` will use the internal declarations when targeting pre-C++-23
+ on Windows platforms as the MSVC support requires newer C++ standard.
- Correct ``_Static_assert`` to accept the same set of extended integer
constant expressions as is accpted in other contexts that accept them.
This fixes `Issue 57687 <https://github.com/llvm/llvm-project/issues/57687>`_.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139266.483327.patch
Type: text/x-patch
Size: 1500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221215/73b05419/attachment.bin>
More information about the cfe-commits
mailing list