[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 13 15:31:44 PST 2022


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, but please make sure the `.rst` file builds with `sphinx`.



================
Comment at: clang/docs/LanguageExtensions.rst:644
                                              magnitude than x
+ T__builtin_elementwise_canonicalize(T x)  return the platform specific canonical encoding of a floating-point number             floating point types
+
----------------
arsenm wrote:
> fhahn wrote:
> > I think this needs re-flowing , otherwise the table won't be rendered properly? Same for the next line
> I'm not really sure what's going on with the formatting or how this works. It looks worse on Phabricator than in the editor 
I just tried this locally and the entries seem to be mis-aligned, which gets rejected by `sphinx`:

```
Warning, treated as error:
../tools/clang/docs/LanguageExtensions.rst:644:Malformed table.
Text in column margin in table line 16.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139640/new/

https://reviews.llvm.org/D139640



More information about the cfe-commits mailing list