[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

Finlay Marno via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 29 07:56:36 PST 2022


FMarno added a comment.

@Anastasia I feel like I am following the guidance you quoted here. The defines I've deleted in `opencl-c-base.h` are blocking the possibility of `-cl-ext` working and would also get in the way of undefine preprocessor symbols working. 
If there is a problem with the additions to `OpenCLExtensions.def` then we'll need to rework how `InitializeOpenCLFeatureTestMacros` in `initPreprocessor.cpp` works.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137652/new/

https://reviews.llvm.org/D137652



More information about the cfe-commits mailing list