[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

Zakk Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 21 17:43:09 PST 2022


khchen added inline comments.


================
Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:284
+
+class RVVTypeCache {
+private:
----------------
nit: maybe we could add some comments to said the motivation for `RVVTypeCache`. 


================
Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:289
+
+  static uint64_t computeRVVTypeHashValue(BasicType BT, int Log2LMUL,
+                                          PrototypeDescriptor Proto);
----------------
`static` could be eliminated now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138429/new/

https://reviews.llvm.org/D138429



More information about the cfe-commits mailing list