[PATCH] D138088: [clang][docs] Use `option` directive in User's Manual

KAWASHIMA Takahiro via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 18 17:27:17 PST 2022


kawashima-fj added a comment.

In D138088#3937680 <https://reviews.llvm.org/D138088#3937680>, @aaron.ballman wrote:

> Thank you for this cleanup! In general, I thin this looks correct. However, I know we've had to fix a bunch of options that cause the sphinx build to fail (IIRC, oftentimes due to duplicate options) and our precommit CI doesn't test the documentation build. Did you try building the docs locally to ensure there are no new warnings/errors from Sphinx?

Yes. I confirmed no new warnings/errors with the following commands. I used Sphinx packaged by distributions (Ubuntu 22.04 and Debian GNU/Linux 11). Is it sufficient? If no, let me know.

  cmake -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS=clang -DLLVM_ENABLE_SPHINX=ON -DLLVM_INCLUDE_DOCS=ON [other unrelated options ...]
  ninja docs-clang-html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138088/new/

https://reviews.llvm.org/D138088



More information about the cfe-commits mailing list