[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

Alan Zhao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 8 14:35:58 PST 2022


ayzhao added a comment.

This change is causing system-include-extractor.test <https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/test/system-include-extractor.test> to fail on Chrome: https://crbug.com/1382508

The test fails on this assertion <https://github.com/llvm/llvm-project/blob/1a2bc103bba04e8fba574c70c6201ba18ccc08ba/clang-tools-extra/clangd/test/system-include-extractor.test#L66> if the path to the LLVM repository contains the plus sign (+). The actual output replaces the plus sign with the URL escape code %2B, but the still expects the plus sign in the output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133757/new/

https://reviews.llvm.org/D133757



More information about the cfe-commits mailing list