[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 3 13:54:55 PDT 2022


mstorsjo added a comment.

In D137024#3905181 <https://reviews.llvm.org/D137024#3905181>, @mgorny wrote:

>> These workarounds are fine for me, but I wonder if it would be useful with a more direct cmake option to tell it not look for these files at all.
>
> CMake has something like that built-in. I think it's `-DCMAKE_DISABLE_FIND_PACKAGE_LLVM=ON`.

Oh, interesting, I wasn't aware of that one.

I thought more of the lines of telling compiler-rt to entirely skip the codepaths that try to look for these bits, but maybe it's not necessary in the end. Anyway, I'll follow this effort if there are more refactorings coming up in this area.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137024/new/

https://reviews.llvm.org/D137024



More information about the cfe-commits mailing list