[PATCH] D136789: [clang] Remove no-op -fexperimental-new-pass-manager/-fno-legacy-pass-manager flags

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 26 14:04:57 PDT 2022


aeubanks created this revision.
aeubanks added a reviewer: MaskRay.
Herald added a subscriber: StephenFan.
Herald added a reviewer: ctetreau.
Herald added a project: All.
aeubanks requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

These have been no-op for a while and keeping them around may be confusing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136789

Files:
  clang/docs/ReleaseNotes.rst
  clang/include/clang/Driver/Options.td
  clang/test/Driver/flegacy-pass-manager.c


Index: clang/test/Driver/flegacy-pass-manager.c
===================================================================
--- clang/test/Driver/flegacy-pass-manager.c
+++ /dev/null
@@ -1,13 +0,0 @@
-/// -fno-legacy-pass-manager and -fexperimental-new-pass-manager are retained
-// as no-ops. The inverted options are no longer supported.
-
-// RUN: %clang -### -c -fno-legacy-pass-manager %s 2>&1 | FileCheck %s
-// RUN: not %clang -### -flegacy-pass-manager %s
-
-// RUN: %clang -### -c -fexperimental-new-pass-manager %s 2>&1 | FileCheck %s
-// RUN: not %clang -### -fno-experimental-new-pass-manager %s
-
-// Just check that there is no argument unused warning. There is no need to
-// pass any cc1 options.
-
-// CHECK-NOT: warning: argument unused
Index: clang/include/clang/Driver/Options.td
===================================================================
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -2014,10 +2014,6 @@
   HelpText<"Enables the global instruction selector">;
 def fexperimental_isel : Flag<["-"], "fexperimental-isel">, Group<f_clang_Group>,
   Alias<fglobal_isel>;
-def fno_legacy_pass_manager : Flag<["-"], "fno-legacy-pass-manager">,
-  Group<f_clang_Group>, Flags<[CC1Option, NoArgumentUnused]>;
-def fexperimental_new_pass_manager : Flag<["-"], "fexperimental-new-pass-manager">,
-  Group<f_clang_Group>, Flags<[CC1Option]>, Alias<fno_legacy_pass_manager>;
 def fexperimental_strict_floating_point : Flag<["-"], "fexperimental-strict-floating-point">,
   Group<f_clang_Group>, Flags<[CC1Option]>,
   HelpText<"Enables experimental strict floating point in LLVM.">,
Index: clang/docs/ReleaseNotes.rst
===================================================================
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -158,6 +158,8 @@
       }
     }
 
+  - The -fexperimental-new-pass-manager and -fno-legacy-pass-manager flags have
+    been removed. These have been no-ops since the last release.
 
 What's New in Clang |release|?
 ==============================


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136789.470928.patch
Type: text/x-patch
Size: 2052 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221026/bd623193/attachment.bin>


More information about the cfe-commits mailing list