[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

Mon Oct 24 11:30:08 PDT 2022

erichkeane added a comment.

In D134128#3879295 <https://reviews.llvm.org/D134128#3879295>, @erichkeane wrote:

> I'm reasonably OK with this, I'm disappointed the 'skip for specialization' is what was required, but I don't think I know of a better way.  I'll hold off approving this until I've confirmed that libcxx tests + libcxx-modules-tests are properly passing as a result of this.

I wnated to test this config locally, but it doesnt seem to be working for me?  But you can modify this patch modify the DELETEME file in libcxx (see how he did it here: https://reviews.llvm.org/D127695 put it in the review but didnt commit it), it will cause libcxx pre-commit, which I think we shoudl do.  Just don't commit the DELETEME file obviously.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134128/new/

https://reviews.llvm.org/D134128