[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

Sat Oct 22 15:28:15 PDT 2022

calebzulawski marked an inline comment as done.
calebzulawski added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2147
+    default:
+      // We shouldn't get here, unless the target OS doesn't have an SDK.
+      break;
----------------
calebzulawski wrote:
> carlocab wrote:
> > `llvm_unreachable`? Or `assert`, at least.
> I'm not sure that's correct--what if you target something like `x86_64-unknown-none`?  I figured it would be safest to fall back to the previous behavior of simply not providing a sysroot.
Realizing this is never hit for non-darwin targets anyway, added the `llvm_unreachable`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136315/new/

https://reviews.llvm.org/D136315