[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 20 10:48:16 PDT 2022


aaron.ballman added a comment.

Thank you for the fix!

Can you add test coverage to show the behavioral change? You can either position the problematic null argument on its own line (so you can validate the correct position) or use `-fdiagnostics-print-source-range-info` to check a specific range. Also, can you add a release note about the fix to `clang/docs/ReleaseNotes.rst`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136355/new/

https://reviews.llvm.org/D136355



More information about the cfe-commits mailing list