[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

Xiang Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 18 10:50:17 PDT 2022


python3kgae added a comment.

In D133668#3847999 <https://reviews.llvm.org/D133668#3847999>, @rjmccall wrote:

> If you have `char`, would you want it to promote?  Because turning `char` to `_BitInt(8)` is breaking with C on other grounds (like aliasing), for better or worse.  So if you just don't want promotion, maybe you really should just disable promotion.

Hi @rjmccall,
Thanks for the review.
I've switched back to short and disabled the integer promotion for HLSL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133668/new/

https://reviews.llvm.org/D133668



More information about the cfe-commits mailing list