[PATCH] D135595: [HLSL] Add utility to convert environment to stage

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 12 13:45:01 PDT 2022


beanz added inline comments.


================
Comment at: clang/include/clang/Basic/HLSLRuntime.h:39
+  return static_cast<ShaderStage>(Pipeline);
+}
+
----------------
bogner wrote:
> You're not actually introducing the dependency here (it was already there), but neither `ShaderStage` in LangOptions.h nor the shader stage `EnvironmentType` in Triple.h mention that they need to be kept in sync with the other. Can you add comments to both that note the relationship?
Will do!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135595/new/

https://reviews.llvm.org/D135595



More information about the cfe-commits mailing list