[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

Zahira Ammarguellat via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 6 13:48:19 PDT 2022


zahiraam added a comment.

In D135097#3840706 <https://reviews.llvm.org/D135097#3840706>, @aaron.ballman wrote:

> I'm also okay with this direction. I took a look to see if people seemed to be using this option in their build scripts (maybe we would need a louder deprecation period), and it seems like most of the uses out there are in forks of Clang. Once I excluded things that looked too clang-like, I spotted: https://sourcegraph.com/search?q=context:global+-file:.*test.*+-file:.*clang.*+-file:Tools.cpp+-menable-unsafe-fp-math&patternType=standard -- I don't have the impression we need a deprecation period for this. (Do we consider this to be a potentially breaking change we need to list in the release notes/announcements/clang-vendors?) The changes should have a release note, regardless of what heading we put it under.

@aaron.ballman There is a chapter in the RN called "Removed Compiler Flags". Some text should definitely be added there. I let other people chime in for the "potentially breaking" in the RN or somewhere else.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135097/new/

https://reviews.llvm.org/D135097



More information about the cfe-commits mailing list