[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 10:57:37 PDT 2022


tra added a comment.

In D135076#3831563 <https://reviews.llvm.org/D135076#3831563>, @MaskRay wrote:

> Another idea is to reject multiple `-o` if some are used as the `Joined` form. Note: multiple `Separate` `-o` should be allowed.
> It will not catch `-offload-*` when `-o output` is not specified, but is probably useful enough.

Is there a reason we should not always reject `-o<existing double-dash option>`? I doubt there are many real life uses of such output names and if/when someone needs them, it's easy enough to disambiguate by using a separate `-o` argument or `-o./output`.
This would address the issue for all `--o*` options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135076/new/

https://reviews.llvm.org/D135076



More information about the cfe-commits mailing list