[PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 09:23:09 PDT 2022


shafik added inline comments.


================
Comment at: clang/include/clang/AST/ExprCXX.h:733
 
+  static CXXBoolLiteralExpr *Create(const ASTContext &C, bool Val, QualType Ty,
+                                    SourceLocation Loc) {
----------------
I think this makes sense but if we are going to do this refactor then we should clean up all the locations we are currently doing `new (Context) CXXBoolLiteralExpr(....)` as well.

Maybe that should be the initial PR and then this change would be a follow-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135169/new/

https://reviews.llvm.org/D135169



More information about the cfe-commits mailing list