[PATCH] D134801: [clang][Interp] Implement ConditionalOperators

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 28 10:46:42 PDT 2022


shafik added inline comments.


================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:357
+
+  if (!this->visit(Condition))
+    return false;
----------------
Maybe I am misunderstanding what this is doing but can't we just check the result of the condition and then just visit either the true or false branch?  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134801/new/

https://reviews.llvm.org/D134801



More information about the cfe-commits mailing list