[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 14:49:20 PDT 2022


phosek added inline comments.


================
Comment at: clang/lib/CodeGen/CGVTables.cpp:1288-1293
+  llvm::Type *ComponentType;
+  if (UseRelativeLayout(*this))
+    ComponentType = Int32Ty;
+  else
+    ComponentType = Int8PtrTy;
+  CharUnits ComponentWidth = GetTargetTypeStoreSize(ComponentType);
----------------
Could we use `getVTableComponentType` method here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134687/new/

https://reviews.llvm.org/D134687



More information about the cfe-commits mailing list