[PATCH] D134544: [clang-cl] Implement /ZH: flag

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 23 11:55:56 PDT 2022


hans added a comment.

nice!



================
Comment at: clang/include/clang/Basic/CodeGenOptions.def:344
 
+/// Set debug info source file hashing algorithm
+ENUM_CODEGENOPT(DebugSrcHashAlgorithm, SrcHashAlgorithm, 2, CSK_MD5)
----------------
ultra nit: period. But maybe the comment is superfluous?


================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:106
+  enum SrcHashAlgorithm {
+    CSK_MD5,
+    CSK_SHA1,
----------------
what does CSK stand for here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134544/new/

https://reviews.llvm.org/D134544



More information about the cfe-commits mailing list