[PATCH] D134458: [AST] Add msvc-specific C++11 attribute 'msvc::no_unique_address'

Thu Sep 22 13:50:53 PDT 2022

RIscRIpt added a comment.

In D134458#3809570 <https://reviews.llvm.org/D134458#3809570>, @aaron.ballman wrote:

> Can you split this out into two separate reviews?

Sure, done: https://reviews.llvm.org/D134475

================
Comment at: clang/include/clang/Basic/Attr.td:3497
+
+def MSNoUniqueAddress : InheritableAttr, TargetSpecificAttr<TargetItaniumCXXABI> {
+  let LangOpts = [MicrosoftExt];
----------------
aaron.ballman wrote:
> Hmmm, very odd that the msvc no unique address attribute is only supported on Itanium ABI targets. Should this be `TargetMicrosoftCXXABI` instead?
My fault, I did blind copy-paste completely forgetting about ABI!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134458/new/

https://reviews.llvm.org/D134458