[PATCH] D133329: [Driver] Add --gcc-install-dir=

Sun Sep 18 10:59:49 PDT 2022

MaskRay added a comment.

In D133329#3798166 <https://reviews.llvm.org/D133329#3798166>, @mgorny wrote:

> Hmm, apparently this could be achieved by making it a "CoreOption".

I don't think it is appropriate to have `CoreOption`. The Windows dxc support appears to have nothing to do with gcc installation unless I am mistaken.
It's for configuration file support to figure out how to work with `--driver-mode`, not this patch which causes no test failure if you don't place `--driver-mode` in a default config file (which isn't a supported case).

In general I am not sure we can reasonably support placing arbitrary options into a default config and expect all test suite to pass.
For `--rtlib=` `--unwindlib=` `--stdlib=` etc, yeah, we currently add the option to fix many parameters, but it is infeasible to control all the variables.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133329/new/

https://reviews.llvm.org/D133329