[PATCH] D133634: [clang] Allow vector of BitInt

[Xiang Li via Phabricator via cfe-commits]

python3kgae marked an inline comment as done.
python3kgae added inline comments.


================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:3111
     Extra.mangleSourceName("__vector");
-    Extra.mangleType(QualType(ET, 0), Range, QMM_Escape);
+    Extra.mangleType(QualType(ET ? static_cast<const Type *>(ET) : BitIntTy, 0),
+                     Range, QMM_Escape);
----------------
craig.topper wrote:
> Why is an explicit cast needed here?
Because ET and BitIntTy have incompatible types for the select. (error : incompatible operand types ('const clang::BuiltinType *' and 'const clang::BitIntType *')

cast to const Type * will make them agree as const Type *.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133634/new/

https://reviews.llvm.org/D133634