[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:126
+  <https://clang.llvm.org/docs/Modules.html#use-declaration>`_ are now
+  diagnosed even when the includer is a textual header.
 
----------------
aaron.ballman wrote:
> You should mention `-fno-modules-validate-textual-header-includes` here so that users know there's a transition flag available. Do you expect we'd like to remove that flag in the future, or do you expect we'll need to carry it around "forever"?
I'm hopeful that we only need to keep the flag around while the affected users are transitioning. We know we need it inside Google because with this patch we find a bunch of layering issues that we thought we were already diagnosing, but weren't; I don't know how many other Clang users are actually making use of this part of the module maps functionality. My aim would be to remove the flag after the next release, if possible.

Extended documentation to mention the flag and that it's going away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132779/new/

https://reviews.llvm.org/D132779