[PATCH] D129488: [Sema] Fix evaluation context of immediate functions in default arguments

Tue Aug 30 07:30:25 PDT 2022

ilya-biryukov added a reviewer: aaron.ballman.
ilya-biryukov added a subscriber: aaron.ballman.
ilya-biryukov added a comment.

This seems to mostly work and ready for another round of review, but I still need to update the codegen test, it seems it has caught an error with default-initilization of globals.
For reference, I have also tried forcing evaluation of relevant calls during semantic analysis, but did not finish it. See my attempt here if interested: https://reviews.llvm.org/D132941.

Current design of Clang does not seem to be friendly to this kind of change as this involves having different expressions inside `CXXDefaultArgExpr` even if the underlying parameter is the same.

@aaron.ballman could you take a look at this and share your thoughts too?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129488/new/

https://reviews.llvm.org/D129488