[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 29 09:37:41 PDT 2022


jdoerfert requested changes to this revision.
jdoerfert added a comment.
This revision now requires changes to proceed.

I think the code as is upstream is fine. The test input is problematic. There is no guarantee, or even any argument, that stdbool is not included by the compiler or any header (system or not). If the user writes conflicting cod with the system, that calls for problems down the line.

Long story short, I'd abandon this for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131639/new/

https://reviews.llvm.org/D131639



More information about the cfe-commits mailing list