[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

[Whitney Tsang via Phabricator via cfe-commits]

Whitney added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:4702
+
+  // Add or replace -ftime-trace<path>` to the correct one to all clang jobs
+  for (auto &J : C.getJobs()) {
----------------
dongjunduo wrote:
> Whitney wrote:
> > Do you mean Add or replace the modified `-ftime-trace=<path>` to all clang jobs?
> Right
ic, can you please have the comment updated?


================
Comment at: clang/lib/Driver/Driver.cpp:4739
+
+      // replace `-ftime-trace=<path>`
+      auto &JArgs = J.getArguments();
----------------
dongjunduo wrote:
> Whitney wrote:
> > should we also replace `-ftime-trace`?
> The work before here is to infer the correct path to store the time-trace file.
> 
> After that, the <path> in `-ftime-trace=<path>` should be replaced by the infered correct path.
> 
> We do not need to replace `-ftime-trace` then.
What happens when `-ftime-trace` is given by the user? Do you have both `-ftime-trace=<path>` and `-ftime-trace` as arguments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131469/new/

https://reviews.llvm.org/D131469