[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

Fri Aug 26 09:59:20 PDT 2022

yihanaa added a comment.

In D131979#3752131 <https://reviews.llvm.org/D131979#3752131>, @rjmccall wrote:

> I'm a little worried about the shift to emit an unconditional error on `volatile`.  Can we at least separate that into its own patch and just fix the bug in this one?  And please try to reach out whoever originally added this feature to see if that restriction is okay vs. just ignoring it, because it certainly looks like the `volatile` exception was intentionally designed.
>
> Other than that, this looks great, thank you.

Thanks for your review, John,I agree. If we just fix this crash, I didn't think of a good way to remove the call to getSubExprAsWritten in CodeGen. But I'll try to fix crash first.

Maybe there should be a discussion about emit an error for volatile in the community.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131979/new/

https://reviews.llvm.org/D131979