[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 24 10:36:16 PDT 2022


phosek added a comment.

In D132440#3744960 <https://reviews.llvm.org/D132440#3744960>, @mstorsjo wrote:

>> This reverts commit eca29d4a37b8d1c93fe99be6289a60bb11cf789d <https://reviews.llvm.org/rGeca29d4a37b8d1c93fe99be6289a60bb11cf789d> since the test fails in the per-target-runtime-dir layout.
>
> Does that mean that the testcase ended up looking at other libraries next to clang, in the build dir where the tests are run? That's rather annoying... I guess it could be fixed by adding `-resource-dir` in the testcase? (And ideally in the future, by making a harder switch between the two runtime install layouts in clang, as discussed on Discourse.)

Yes, that's the issue, I added `-resource-dir` which is the solution we use in other tests as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132440/new/

https://reviews.llvm.org/D132440



More information about the cfe-commits mailing list