[PATCH] D132430: [clang][modules] Track affecting modules

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir added inline comments.


================
Comment at: clang/test/ClangScanDeps/modules-incomplete-umbrella.c:82
+// CHECK_TU-NEXT:       "command-line": [
+// CHECK_TU:            ],
+// CHECK_TU-NEXT:       "file-deps": [
----------------
jansvoboda11 wrote:
> benlangmuir wrote:
> > The test should probably cover the imports in the command-lines.
> Most `-fmodule-file=` checks were removed in D132066, since these are likely to change in the future, and I'm okay with relying on `"clang-module-deps"`. I can see the argument that in this particular case the dependencies are not ordinary imports, but somewhat of an edge case, so I'm fine with adding the checks.
I'd prefer to add the checks in this specific case. I agree it's not relevant to most other tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132430/new/

https://reviews.llvm.org/D132430