[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 20 18:10:03 PDT 2022


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/test/Driver/pic-flags.f90:69
+! CHECK-ROPI: "-mrelocation-model" "ropi"
+! CHECK-ROPI-NOT: -pic
+
----------------
I'd use `! CHECK-ROPI-NOT: "-pic`

otherwise there is a risk that the pattern matches a temporary file named `*-pic*`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131533/new/

https://reviews.llvm.org/D131533



More information about the cfe-commits mailing list