[PATCH] D131553: [analyzer] exploded-graph-rewriter: Fix python3 string encoding issues

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 10 13:06:35 PDT 2022


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Thanks for figuring all of this out! Looks great!

That's right, we can't and probably shouldn't test graphviz.



================
Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:862
                     fp.write(data)
-                print('Done! Please remember to remove the file.')
                 return filename
----------------
I think the reminder is still relevant. These files can be like 100mb in size, and now that they aren't in /tmp they aren't autocleaned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131553/new/

https://reviews.llvm.org/D131553



More information about the cfe-commits mailing list