[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In D126907#3711956 <https://reviews.llvm.org/D126907#3711956>, @ChuanqiXu wrote:

> In D126907#3710656 <https://reviews.llvm.org/D126907#3710656>, @erichkeane wrote:
>
>> Ok, fixed the test failure in clang, AND it managed to fix 
>> all the failures in libcxx!
>>
>> HOWEVER, it appears that libcxx/test/libcxx/modules_include.sh.cpp
>> is now hanging?
>>
>> I don't know much about the modules implementation (perhaps someone
>> like @ChuanqiXu  can help out?), so I'm at least somewhat stuck until
>> I can figure out how to get it to give me more info.
>
> I may not be able to look into the details recently. What's the error message from the modules?

Looking deeper... this test is a monstrosity (https://github.com/llvm/llvm-project/blob/main/libcxx/test/libcxx/modules_include.sh.cpp), and I'm not necessarily sure it is necessarily modules-related, other than enabling it on every header.  So it just seems like one of the STL headers is taking significantly longer to compile?  I have no idea how to move forward with this... it AT LEAST "finishes", but it takes a very long time to get through now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907