[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

Abid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 8 15:25:44 PDT 2022


abidmalikwaterloo added a comment.

In D105255#3707533 <https://reviews.llvm.org/D105255#3707533>, @clementval wrote:

> In D105255#3707495 <https://reviews.llvm.org/D105255#3707495>, @raghavendhra wrote:
>
>> In D105255#3707088 <https://reviews.llvm.org/D105255#3707088>, @abidmalikwaterloo wrote:
>>
>>> In D105255#3706602 <https://reviews.llvm.org/D105255#3706602>, @raghavendhra wrote:
>>>
>>>> @abidmalikwaterloo Can you please check your last patch pushed for review? https://buildkite.com/llvm-project/diff-checks/builds/117796 states it can not apply your patch something to do with the usage of diff --update <patch>? Can you please check?
>>>
>>> @raghavendhra  `I tried to correct it but could not figure out the solution. Do you have any? I am not experienced with the phabricator framework.  One solution is to submit another patch with all changes till today and abandon this one.`
>>
>> Sorry, I am new to phabricator as well. I use "arc diff" to upload my revisions for review after addressing review comments. If no one responds probably I am fine with new review and abandoning this one.
>
> Did you try `arc diff --update D105255 ` from your branch?

`yes, I tried this. Actually,  I updated the patch. through this`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105255/new/

https://reviews.llvm.org/D105255



More information about the cfe-commits mailing list