[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

Mon Aug 8 05:06:44 PDT 2022

nemanjai added a comment.

Why? There are many years of precedent for using `LLVM_FALLTHROUGH` and it is very clear and obvious. What do we gain by getting rid of it?
Don't get me wrong, I am not super opposed to using a standard string instead of an LLVM-specific macro. However, it seems that this leaves us with a mixture of the macro and the standard attribute. If we are ready to replace all occurrences in all projects and get rid of the macro altogether (with some warning to downstream users), that seems reasonable. Replacing only some of them seems worse than what we now have.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131346/new/

https://reviews.llvm.org/D131346