[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

Douglas Yung via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 31 18:43:34 PDT 2022


dyung added a comment.

In D130788#3689918 <https://reviews.llvm.org/D130788#3689918>, @sunho wrote:

> In D130788#3689820 <https://reviews.llvm.org/D130788#3689820>, @dyung wrote:
>
>> In D130788#3689795 <https://reviews.llvm.org/D130788#3689795>, @sunho wrote:
>>
>>> The test isn't supposed to be ran on windows -- we don't support exception on windows at all yet. I guess XFAIL: windows-msvc, windows-gnu is not working out.
>>
>> If you don't want the test run on Windows, I think what you want is probably `system-windows` rather than `windows-msvc` and `windows-gnu`. The former will mark as XFAIL when it is run on Windows, while the latter will mark as XFAIL when the target triple includes those strings.
>
> Should have been fixed in https://github.com/llvm/llvm-project/commit/773d51ce3bedd091539aa86a5e5fc15a9174ff7b. Can you check it out?

https://lab.llvm.org/buildbot/#/builders/216/builds/7647

That seems to have worked. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130788/new/

https://reviews.llvm.org/D130788



More information about the cfe-commits mailing list