[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 11 08:29:58 PDT 2022


JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

Code looks good to me. It's hard to be sure whether it works without running a bunch of hip test cases through it, have you already done so? If it doesn't work out of the box it should be close enough to fix up post commit, e.g. when trying to move hip over to this by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128914/new/

https://reviews.llvm.org/D128914



More information about the cfe-commits mailing list