[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

Richard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 1 13:46:34 PDT 2022


LegalizeAdulthood added a comment.

In D128157#3612741 <https://reviews.llvm.org/D128157#3612741>, @myhsu wrote:

> You forgot to add <https://github.com/llvm/llvm-project/commit/b2cb7e81f8978ccce5c5e7b316480b88785ca9cc> "Differential Revison: https://reviews.llvm.org/DXXXXXX" in the commit message, which is how Phabricator identifies the differential to close. I don't think it has anything to do with rebasing.

Oh, OK, that makes sense, oops.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128157/new/

https://reviews.llvm.org/D128157



More information about the cfe-commits mailing list