[PATCH] D128022: [HIP] add -fhip-kernel-arg-name

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 5 inline comments as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6353
       CmdArgs.push_back("-fgpu-allow-device-init");
+    if (Args.hasFlag(options::OPT_fhip_kernel_arg_name,
+                     options::OPT_fno_hip_kernel_arg_name, false))
----------------
MaskRay wrote:
> Use `addOptInFlag`
will do when committing


================
Comment at: clang/test/Driver/hip-options.hip:120
+
+// Check -fhip-kernel-arg-name is passed to clang -cc1.
+
----------------
MaskRay wrote:
> This comment is redundant. There is only one CHECK line and the string is clear there.
will remove when commiting


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128022/new/

https://reviews.llvm.org/D128022