[PATCH] D128337: [clang-tidy] Extend spelling for CheckOptions

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 22 05:05:06 PDT 2022


njames93 created this revision.
njames93 added reviewers: aaron.ballman, alexfh.
Herald added subscribers: carlosgalvezp, arphaman, xazax.hun.
Herald added a project: All.
njames93 requested review of this revision.
Herald added subscribers: cfe-commits, aheejin.
Herald added a project: clang-tools-extra.

The current way to specify CheckOptions is pretty verbose and unintuitive.
Given that the options are a dictionary it makes much more sense to treat them as such in the config files.
Example:

  CheckOptions: {SomeCheck.Option: true, SomeCheck.OtherOption: 'ignore'}
  # Or
  CheckOptions:
    SomeCheck.Option: true
    SomeCheck.OtherOption: 'ignore'

This change will still handle the old syntax with no issue, ensuring we don't screw up users current config files.

The only observable differences are support for the new syntax and `-dump=config` will emit using the new syntax.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D128337

Files:
  clang-tools-extra/clang-tidy/ClangTidyOptions.cpp
  clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp
  clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/Contributing.rst
  clang-tools-extra/docs/clang-tidy/index.rst
  clang-tools-extra/test/clang-tidy/checkers/google-module.cpp
  clang-tools-extra/test/clang-tidy/infrastructure/Inputs/config-files/4/key-dict/.clang-tidy
  clang-tools-extra/test/clang-tidy/infrastructure/config-files.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128337.438981.patch
Type: text/x-patch
Size: 11660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220622/1dd4b1f0/attachment.bin>


More information about the cfe-commits mailing list