[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

Fri Jun 17 06:18:36 PDT 2022

erichkeane accepted this revision.
erichkeane added inline comments.
This revision is now accepted and ready to land.

================
Comment at: clang/include/clang/AST/DeclCXX.h:1430
+  /// out of which one will be selected at the end.
+  /// This is called separately from addedMember because it has to be deferred
+  /// to the completion of the class.
----------------
royjacobson wrote:
> erichkeane wrote:
> > @aaron.ballman  is messing around with addedMember recently... I wonder if there are OTHER decisions that need to be updated/moved here?
> Do you know what papers/DRs he's working on? It seemed like most constexpr stuff is done per-function and not per-class.
> 
> I don't think there's something else that needs to change but it's definitely possible I missed something.. I went through addedMember and tried to remove everything destructor related basically.
> 
> 
He's working on DR647, which does a lot of work with special member functions/constexpr/consteval constructors.

That said, I believe he said it isn't a problem, they are related, but not conflicting in a way that he had.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126194/new/

https://reviews.llvm.org/D126194