[PATCH] D127771: [HIP] fix long double size

Tue Jun 14 11:49:35 PDT 2022

yaxunl added a comment.

In D127771#3582640 <https://reviews.llvm.org/D127771#3582640>, @tra wrote:

> AFAICT, the test case you've added works fine with the compiler at HEAD: https://cuda.godbolt.org/z/q3xYMfdeb
> I guess it only shows up in assertion-enabled builds. Can you check what happens if you run the test case compiled as CUDA? I suspect it will have the same issue -- we don't override setAuxTarget at all.

The assertion only happens with assertion-enabled builds. However, the test is able to detect the issue with assertion-disabled builds since it checks the sizeof(long double). In the old build it is 16.

The lit test contains run line for nvptx. It seems nvptx is not subject to this issue since sizeof(long double)==8.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127771/new/

https://reviews.llvm.org/D127771