[PATCH] D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

Fri Jun 10 11:37:56 PDT 2022

aaron.ballman added inline comments.

================
Comment at: clang/test/Preprocessor/suggest-typoed-directive.c:1-2
+// clang-format off
+
 // RUN: %clang_cc1 -fsyntax-only -verify=pre-c2x-cpp2b %s
----------------
akyrtzi wrote:
> akyrtzi wrote:
> > aaron.ballman wrote:
> > > You can remove this -- we don't require test files to be formatted properly, and formatting comments can quickly become distracting.
> > The debian bot failed for this patch with `clang-format` complaining about the test file. Was this unintentional?
> For reference the bot failure is here: https://buildkite.com/llvm-project/premerge-checks/builds/96481#01814013-61ed-4a53-a9d0-4d1a183ac360
Yeah -- the precommit CI bots still check it and report back failures, which is incredibly frustrating given how much noise that generates. I've filed https://github.com/llvm/llvm-project/issues/55982 to track that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127251/new/

https://reviews.llvm.org/D127251