[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 9 10:01:46 PDT 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

> Good question. Unless this functionality already has tests (and I'm gathering it doesn't), I think we can rely on Clang being the test. (Though we should consider ourselves on notice for adding robust unit tests at some point.)

I don't know of tests for it, so I'm okay with that approach. LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126832/new/

https://reviews.llvm.org/D126832



More information about the cfe-commits mailing list