[PATCH] D126536: [pseudo] Add grammar annotations support.

[Haojian Wu via Phabricator via cfe-commits]

hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Grammar.h:219
+  // ExtensionID is the index of the table.
+  std::vector<std::string> AttributeValues;
 };
----------------
sammccall wrote:
> looking at this again, ExtensionNames seems clearer as ExtensionNames[ExtID] seems more obvious that the kinds agree. But up to you
I considered extensionNames, but decided to use AttributeValues. `AttributeValues` corresponds to the syntactic grammar `[key=value]` where we call value as the attribute value, while using `ExtensionNames` is less clearer.  And yeah `AttributeValues[ExtID]` is somehow confusing, but I think it is fine, as it is just print code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126536/new/

https://reviews.llvm.org/D126536