[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

Tue May 31 09:24:42 PDT 2022

smeenai added a comment.

In D126397#3547060 <https://reviews.llvm.org/D126397#3547060>, @thakis wrote:

> Even after this, you still have to explicitly set `-DCMAKE_SYSTEM_NAME=Darwin` when building clang for mac/arm on mac/intel. Given that the host and target systems are both mac, that's a bit weird. llvm-tblgen doesn't need this, it just works as long as you set `LLVM_USE_HOST_TOOLS=ON`. Should pseudo-gen honor LLVM_USE_HOST_TOOLS too? It looks like it's basically the same situation.
>
> (It's only the 2nd compiled binary in all of llvm that needs to run as part of the build (if you count the various tblgen binaries as a single binary). Maybe it'd make sense to make this a tblgen-based tool? Then this would've Just Worked.).

I was checking for `CMAKE_CROSSCOMPILING` instead of `LLVM_USE_HOST_TOOLS` because I didn't want this to fire for `LLVM_OPTIMIZED_TABLEGEN`, but I guess `LLVM_OPTIMIZED_TABLEGEN` could be interpreted as a generic "optimized host tools" option in that case, given that the NATIVE build is always Release.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126397/new/

https://reviews.llvm.org/D126397